From 252b023f0d3880a784687cb4548edf578944a2c2 Mon Sep 17 00:00:00 2001 From: Usman Baig Date: Wed, 4 Feb 2026 22:41:48 +0100 Subject: [PATCH] fix: refactor FunnelReportPage to optimize theme handling by moving chart color logic into useMemo, improving performance and code clarity --- app/sites/[id]/funnels/[funnelId]/page.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/sites/[id]/funnels/[funnelId]/page.tsx b/app/sites/[id]/funnels/[funnelId]/page.tsx index ac8084d..d5bedac 100644 --- a/app/sites/[id]/funnels/[funnelId]/page.tsx +++ b/app/sites/[id]/funnels/[funnelId]/page.tsx @@ -51,6 +51,12 @@ export default function FunnelReportPage() { loadData() }, [siteId, funnelId, dateRange]) + const { resolvedTheme } = useTheme() + const chartColors = useMemo( + () => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT), + [resolvedTheme] + ) + const loadData = async () => { try { setLoading(true) @@ -98,12 +104,6 @@ export default function FunnelReportPage() { conversion: s.conversion })) - const { resolvedTheme } = useTheme() - const chartColors = useMemo( - () => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT), - [resolvedTheme] - ) - return (