ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

refactor: streamline data loading in FunnelsPage and FunnelReportPage by reintroducing useEffect hooks for improved state management and responsiveness

Browse Source
This commit is contained in:
Usman Baig
2026-02-04 23:17:17 +01:00
parent 252b023f0d
commit 8bbe508657
2 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/sites/[id]/funnels/[funnelId]/page.tsx
View File

@@ -47,16 +47,6 @@ export default function FunnelReportPage() {
const [dateRange, setDateRange] = useState(getDateRange(30)) const [dateRange, setDateRange] = useState(getDateRange(30))
const [isDatePickerOpen, setIsDatePickerOpen] = useState(false) const [isDatePickerOpen, setIsDatePickerOpen] = useState(false)
useEffect(() => {
loadData()
}, [siteId, funnelId, dateRange])
const { resolvedTheme } = useTheme()
const chartColors = useMemo(
() => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT),
[resolvedTheme]
)
const loadData = async () => { const loadData = async () => {
try { try {
setLoading(true) setLoading(true)
@@ -73,6 +63,16 @@ export default function FunnelReportPage() {
} }
} }
useEffect(() => {
loadData()
}, [siteId, funnelId, dateRange])
const { resolvedTheme } = useTheme()
const chartColors = useMemo(
() => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT),
[resolvedTheme]
)
const handleDelete = async () => { const handleDelete = async () => {
if (!confirm('Are you sure you want to delete this funnel?')) return if (!confirm('Are you sure you want to delete this funnel?')) return

8
app/sites/[id]/funnels/page.tsx
View File

@@ -16,10 +16,6 @@ export default function FunnelsPage() {
const [funnels, setFunnels] = useState<Funnel[]>([]) const [funnels, setFunnels] = useState<Funnel[]>([])
const [loading, setLoading] = useState(true) const [loading, setLoading] = useState(true)
useEffect(() => {
loadFunnels()
}, [siteId])
const loadFunnels = async () => { const loadFunnels = async () => {
try { try {
setLoading(true) setLoading(true)
@@ -32,6 +28,10 @@ export default function FunnelsPage() {
} }
} }
useEffect(() => {
loadFunnels()
}, [siteId])
const handleDelete = async (e: React.MouseEvent, funnelId: string) => { const handleDelete = async (e: React.MouseEvent, funnelId: string) => {
e.preventDefault() // Prevent navigation e.preventDefault() // Prevent navigation
if (!confirm('Are you sure you want to delete this funnel?')) return if (!confirm('Are you sure you want to delete this funnel?')) return