ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

refactor: remove activeTab state update from handleTabChange in OrganizationSettings to streamline tab navigation logic

Browse Source
This commit is contained in:
Usman Baig
2026-02-05 15:03:41 +01:00
parent 73f2d3757e
commit f91a991e48
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/settings/OrganizationSettings.tsx
View File

@@ -215,7 +215,7 @@ export default function OrganizationSettings() {
setAuditFetchTrigger(prev => prev + 1) // Trigger fetch setAuditFetchTrigger(prev => prev + 1) // Trigger fetch
}, 500) }, 500)
return () => clearTimeout(timer) return () => clearTimeout(timer)
}, [auditActionFilter, auditLogIdFilter, auditStartDate, auditEndDate, activeTab]) }, [auditActionFilter, auditLogIdFilter, auditStartDate, auditEndDate])
useEffect(() => { useEffect(() => {
if (activeTab === 'audit' && currentOrgId) { if (activeTab === 'audit' && currentOrgId) {
@@ -335,7 +335,7 @@ export default function OrganizationSettings() {
const currentOrgName = members.find(m => m.user_id === user?.id)?.organization_name || 'Organization' const currentOrgName = members.find(m => m.user_id === user?.id)?.organization_name || 'Organization'
const handleTabChange = (tab: 'general' | 'members' | 'billing' | 'audit') => { const handleTabChange = (tab: 'general' | 'members' | 'billing' | 'audit') => {
setActiveTab(tab) // setActiveTab(tab) // Let the useEffect handle the state update based on URL
router.push(`?tab=${tab}`) router.push(`?tab=${tab}`)
} }