ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

feat: enhance error handling in FunnelReportPage by adding support for forbidden access and updating error messages for better user clarity

Browse Source
This commit is contained in:
Usman Baig
2026-02-05 00:10:03 +01:00
parent ceb668890b
commit ffe6f464e6
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/sites/[id]/funnels/[funnelId]/page.tsx
View File

@@ -46,7 +46,7 @@ export default function FunnelReportPage() {
const [dateRange, setDateRange] = useState(getDateRange(30)) const [dateRange, setDateRange] = useState(getDateRange(30))
const [datePreset, setDatePreset] = useState<'7' | '30' | 'custom'>('30') const [datePreset, setDatePreset] = useState<'7' | '30' | 'custom'>('30')
const [isDatePickerOpen, setIsDatePickerOpen] = useState(false) const [isDatePickerOpen, setIsDatePickerOpen] = useState(false)
const [loadError, setLoadError] = useState<'not_found' | 'error' | null>(null) const [loadError, setLoadError] = useState<'not_found' | 'forbidden' | 'error' | null>(null)
const loadData = useCallback(async () => { const loadData = useCallback(async () => {
setLoadError(null) setLoadError(null)
@@ -59,9 +59,11 @@ export default function FunnelReportPage() {
setFunnel(funnelData) setFunnel(funnelData)
setStats(statsData) setStats(statsData)
} catch (error) { } catch (error) {
const is404 = error instanceof ApiError && error.status === 404 const status = error instanceof ApiError ? error.status : 0
setLoadError(is404 ? 'not_found' : 'error') if (status === 404) setLoadError('not_found')
if (!is404) toast.error('Failed to load funnel data') else if (status === 403) setLoadError('forbidden')
else setLoadError('error')
if (status !== 404 && status !== 403) toast.error('Failed to load funnel data')
} finally { } finally {
setLoading(false) setLoading(false)
} }
@@ -101,10 +103,21 @@ export default function FunnelReportPage() {
) )
} }
if (loadError === 'forbidden') {
return (
<div className="w-full max-w-6xl mx-auto px-4 sm:px-6 py-8">
<p className="text-neutral-600 dark:text-neutral-400">Access denied</p>
<Link href={`/sites/${siteId}/funnels`} className="btn-primary mt-4 inline-block">
Back to Funnels
</Link>
</div>
)
}
if (loadError === 'error') { if (loadError === 'error') {
return ( return (
<div className="w-full max-w-6xl mx-auto px-4 sm:px-6 py-8"> <div className="w-full max-w-6xl mx-auto px-4 sm:px-6 py-8">
<p className="text-neutral-600 dark:text-neutral-400 mb-4">Failed to load funnel data</p> <p className="text-neutral-600 dark:text-neutral-400 mb-4">Unable to load funnel</p>
<button type="button" onClick={() => loadData()} className="btn-primary"> <button type="button" onClick={() => loadData()} className="btn-primary">
Try again Try again
</button> </button>