refactor(loading): streamline LoadingOverlay usage in HomePage and AuthCallback to return null during loading states

This commit is contained in:
Usman Baig
2026-01-22 18:36:03 +01:00
parent db6ae6a447
commit 12292b62a8
3 changed files with 5 additions and 5 deletions

View File

@@ -110,12 +110,12 @@ function AuthCallbackContent() {
}
// * Use standard Pulse loading screen to make transition to Home seamless
return <LoadingOverlay portal={false} />
return null
}
export default function AuthCallback() {
return (
<Suspense fallback={<LoadingOverlay portal={false} />}>
<Suspense fallback={null}>
<AuthCallbackContent />
</Suspense>
)

View File

@@ -12,7 +12,7 @@ export default function HomePage() {
const { user, loading } = useAuth()
if (loading) {
return <LoadingOverlay logoSrc="/ciphera_icon_no_margins.png" title="Pulse" portal={false} />
return null
}
if (!user) {
@@ -91,7 +91,7 @@ export default function HomePage() {
// * Wait for organization context before rendering SiteList to avoid "Organization Required" flash
if (user && !user.org_id) {
return <LoadingOverlay logoSrc="/ciphera_icon_no_margins.png" title="Pulse" portal={false} />
return null
}
return (

View File

@@ -154,7 +154,7 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
return (
<AuthContext.Provider value={{ user, loading, login, logout, refresh, refreshSession }}>
{isLoggingOut && <LoadingOverlay logoSrc="/ciphera_icon_no_margins.png" title="Pulse" />}
{(loading || isLoggingOut) && <LoadingOverlay logoSrc="/ciphera_icon_no_margins.png" title="Pulse" />}
{children}
</AuthContext.Provider>
)