ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

fix: refactor FunnelReportPage to optimize theme handling by moving chart color logic into useMemo, improving performance and code clarity

Browse Source
This commit is contained in:
Usman Baig
2026-02-04 22:41:48 +01:00
parent 40dffcdb1e
commit 252b023f0d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/sites/[id]/funnels/[funnelId]/page.tsx
View File

@@ -51,6 +51,12 @@ export default function FunnelReportPage() {
loadData() loadData()
}, [siteId, funnelId, dateRange]) }, [siteId, funnelId, dateRange])
const { resolvedTheme } = useTheme()
const chartColors = useMemo(
() => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT),
[resolvedTheme]
)
const loadData = async () => { const loadData = async () => {
try { try {
setLoading(true) setLoading(true)
@@ -98,12 +104,6 @@ export default function FunnelReportPage() {
conversion: s.conversion conversion: s.conversion
})) }))
const { resolvedTheme } = useTheme()
const chartColors = useMemo(
() => (resolvedTheme === 'dark' ? CHART_COLORS_DARK : CHART_COLORS_LIGHT),
[resolvedTheme]
)
return ( return (
<div className="w-full max-w-6xl mx-auto px-4 sm:px-6 py-8"> <div className="w-full max-w-6xl mx-auto px-4 sm:px-6 py-8">
<div className="mb-8"> <div className="mb-8">