ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

chore: update CHANGELOG.md and DESIGN_SYSTEM.md #31

Merged
uz1mani merged 2 commits from staging into main 2026-02-17 20:25:46 +00:00
Conversation 7 Commits 2 Files Changed 2 +6 -12
uz1mani commented 2026-02-17 20:17:56 +00:00 (Migrated from github.com)
Copy Link

update CHANGELOG.md and DESIGN_SYSTEM.md to reflect footer layout alignment and new color variable usage for SVG/Recharts

update CHANGELOG.md and DESIGN_SYSTEM.md to reflect footer layout alignment and new color variable usage for SVG/Recharts
👍 1
greptile-apps[bot] commented 2026-02-17 20:20:11 +00:00 (Migrated from github.com)
Copy Link

Greptile Summary

This is a documentation-only PR that updates CHANGELOG.md and docs/DESIGN_SYSTEM.md to reflect two changes already shipped in v0.7.0-alpha: the authenticated footer container being aligned to max-w-6xl, and the introduction of --color-brand-orange / --color-brand-orange-rgb CSS variables (injected by the @ciphera-net/ui preset) for use in SVG and Recharts contexts where Tailwind utility classes cannot apply.

Key observations:

  • The CHANGELOG.md addition is accurate and matches the actual Footer.tsx implementation (max-w-6xl mx-auto at line 49).
  • The --color-brand-orange variable is correctly documented and actively used in app/sites/[id]/uptime/page.tsx (lines 316, 333–334, 360, 364).
  • The --color-brand-orange-rgb variable is documented but has no usages anywhere in the codebase — it appears to be forward-documented for future use, but this is not called out in the documentation itself.
  • The docs/DESIGN_SYSTEM.md header metadata — **Last Updated:** 2026-02-06 and **Version:** 1.0 — was not updated to reflect these new additions, leaving the document's own version tracking stale.
  • The @ciphera-net/ui version reference on line 914 (^0.0.45) is outdated; the project is now on ^0.0.57 per package.json.

Confidence Score: 5/5

  • Documentation-only PR with no functional code changes; safe to merge.
  • Both files are purely documentation (Markdown). No application code, logic, or configuration is changed. The documented changes accurately reflect the actual codebase state. Minor metadata staleness (Last Updated date, version number, package version reference) and an undocumented forward-only variable are cosmetic concerns that don't affect runtime behavior.
  • docs/DESIGN_SYSTEM.md — the document metadata (Last Updated, Version, and @ciphera-net/ui version reference) was not updated alongside the content changes.

Important Files Changed
Filename Overview
CHANGELOG.md Adds one new changelog entry under 0.7.0-alpha documenting the footer layout alignment to max-w-6xl; accurate and consistent with the actual Footer.tsx code at line 49.
docs/DESIGN_SYSTEM.md Documents two new CSS variables (--color-brand-orange and --color-brand-orange-rgb) injected by @ciphera-net/ui, and adds a usage note for SVG/Recharts contexts. The --color-brand-orange-rgb variable is documented but not yet used anywhere in the codebase. The document's "Last Updated" date (2026-02-06) and version (1.0) were not bumped to reflect these new additions.

Flowchart

flowchart TD
    A["@ciphera-net/ui Tailwind Preset"] -->|"injects CSS variables"| B["--color-brand-orange: #FD5E0F\n--color-brand-orange-rgb: 253, 94, 15"]
    B --> C["SVG attributes\ne.g. stopColor, stroke, fill"]
    B --> D["Recharts props\ne.g. activeDot fill"]
    B --> E["inline style\ne.g. color: var(--color-brand-orange)"]
    B -.->|"documented but not yet used"| F["rgba(var(--color-brand-orange-rgb), 0.5)"]
    G["--brand-orange (Tailwind token)"] -->|"used via Tailwind classes"| H["bg-brand-orange\ntext-brand-orange\nring-brand-orange"]

Last reviewed commit: ce20205

<h3>Greptile Summary</h3> This is a documentation-only PR that updates `CHANGELOG.md` and `docs/DESIGN_SYSTEM.md` to reflect two changes already shipped in v0.7.0-alpha: the authenticated footer container being aligned to `max-w-6xl`, and the introduction of `--color-brand-orange` / `--color-brand-orange-rgb` CSS variables (injected by the `@ciphera-net/ui` preset) for use in SVG and Recharts contexts where Tailwind utility classes cannot apply. Key observations: - The `CHANGELOG.md` addition is accurate and matches the actual `Footer.tsx` implementation (`max-w-6xl mx-auto` at line 49). - The `--color-brand-orange` variable is correctly documented and actively used in `app/sites/[id]/uptime/page.tsx` (lines 316, 333–334, 360, 364). - The `--color-brand-orange-rgb` variable is documented but has **no usages** anywhere in the codebase — it appears to be forward-documented for future use, but this is not called out in the documentation itself. - The `docs/DESIGN_SYSTEM.md` header metadata — `**Last Updated:** 2026-02-06` and `**Version:** 1.0` — was not updated to reflect these new additions, leaving the document's own version tracking stale. - The `@ciphera-net/ui` version reference on line 914 (`^0.0.45`) is outdated; the project is now on `^0.0.57` per `package.json`. <h3>Confidence Score: 5/5</h3> - Documentation-only PR with no functional code changes; safe to merge. - Both files are purely documentation (Markdown). No application code, logic, or configuration is changed. The documented changes accurately reflect the actual codebase state. Minor metadata staleness (Last Updated date, version number, package version reference) and an undocumented forward-only variable are cosmetic concerns that don't affect runtime behavior. - docs/DESIGN_SYSTEM.md — the document metadata (Last Updated, Version, and @ciphera-net/ui version reference) was not updated alongside the content changes. <details><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | CHANGELOG.md | Adds one new changelog entry under 0.7.0-alpha documenting the footer layout alignment to max-w-6xl; accurate and consistent with the actual Footer.tsx code at line 49. | | docs/DESIGN_SYSTEM.md | Documents two new CSS variables (--color-brand-orange and --color-brand-orange-rgb) injected by @ciphera-net/ui, and adds a usage note for SVG/Recharts contexts. The --color-brand-orange-rgb variable is documented but not yet used anywhere in the codebase. The document's "Last Updated" date (2026-02-06) and version (1.0) were not bumped to reflect these new additions. | </details> </details> <h3>Flowchart</h3> ```mermaid flowchart TD A["@ciphera-net/ui Tailwind Preset"] -->|"injects CSS variables"| B["--color-brand-orange: #FD5E0F\n--color-brand-orange-rgb: 253, 94, 15"] B --> C["SVG attributes\ne.g. stopColor, stroke, fill"] B --> D["Recharts props\ne.g. activeDot fill"] B --> E["inline style\ne.g. color: var(--color-brand-orange)"] B -.->|"documented but not yet used"| F["rgba(var(--color-brand-orange-rgb), 0.5)"] G["--brand-orange (Tailwind token)"] -->|"used via Tailwind classes"| H["bg-brand-orange\ntext-brand-orange\nring-brand-orange"] ``` <sub>Last reviewed commit: ce20205</sub>
greptile-apps[bot] (Migrated from github.com) reviewed 2026-02-17 20:20:18 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

<sub>2 files reviewed, 2 comments</sub> <sub>[Edit Code Review Agent Settings](https://app.greptile.com/review/github) | [Greptile](https://greptile.com?utm_source=greptile_expert&utm_medium=github&utm_campaign=code_reviews)</sub>
docs/DESIGN_SYSTEM.md
@@ -21,10 +21,15 @@ This document defines the visual language and design patterns for Pulse Analytic
--brand-orange: #FD5E0F;
greptile-apps[bot] (Migrated from github.com) commented 2026-02-17 20:20:18 +00:00
Copy Link

--color-brand-orange-rgb documented but unused

This variable is defined in the design system doc as a convenience for rgba() usage, but a search across all .tsx, .ts, and .css files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/DESIGN_SYSTEM.md
Line: 26:26

Comment:
**`--color-brand-orange-rgb` documented but unused**

This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist.

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.
**`--color-brand-orange-rgb` documented but unused** This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist. <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> <details><summary>Prompt To Fix With AI</summary> `````markdown This is a comment left during a code review. Path: docs/DESIGN_SYSTEM.md Line: 26:26 Comment: **`--color-brand-orange-rgb` documented but unused** This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist. <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise. ````` </details>
greptile-apps[bot] commented 2026-02-17 20:20:20 +00:00 (Migrated from github.com)
Copy Link
Additional Comments (1)

docs/DESIGN_SYSTEM.md
Stale document metadata

The Last Updated date and Version fields were not bumped to reflect the new content added in this PR. Since the @ciphera-net/ui version reference on line 914 (^0.0.45) also appears outdated (project is now on ^0.0.57), it may be worth a single pass to bring the header metadata in sync.

**Last Updated:** 2026-02-17
Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/DESIGN_SYSTEM.md
Line: 4:4

Comment:
**Stale document metadata**

The `Last Updated` date and `Version` fields were not bumped to reflect the new content added in this PR. Since the `@ciphera-net/ui` version reference on line 914 (`^0.0.45`) also appears outdated (project is now on `^0.0.57`), it may be worth a single pass to bring the header metadata in sync.

```suggestion
**Last Updated:** 2026-02-17  
```

How can I resolve this? If you propose a fix, please make it concise.
<details> <summary>Additional Comments (1)</summary> **`docs/DESIGN_SYSTEM.md`** **Stale document metadata** The `Last Updated` date and `Version` fields were not bumped to reflect the new content added in this PR. Since the `@ciphera-net/ui` version reference on line 914 (`^0.0.45`) also appears outdated (project is now on `^0.0.57`), it may be worth a single pass to bring the header metadata in sync. ```suggestion **Last Updated:** 2026-02-17 ``` <details><summary>Prompt To Fix With AI</summary> `````markdown This is a comment left during a code review. Path: docs/DESIGN_SYSTEM.md Line: 4:4 Comment: **Stale document metadata** The `Last Updated` date and `Version` fields were not bumped to reflect the new content added in this PR. Since the `@ciphera-net/ui` version reference on line 914 (`^0.0.45`) also appears outdated (project is now on `^0.0.57`), it may be worth a single pass to bring the header metadata in sync. ```suggestion **Last Updated:** 2026-02-17 ``` How can I resolve this? If you propose a fix, please make it concise. ````` </details> </details>
uz1mani (Migrated from github.com) reviewed 2026-02-17 20:23:06 +00:00
docs/DESIGN_SYSTEM.md
@@ -21,10 +21,15 @@ This document defines the visual language and design patterns for Pulse Analytic
--brand-orange: #FD5E0F;
uz1mani (Migrated from github.com) commented 2026-02-17 20:23:06 +00:00
Copy Link

Issue: --color-brand-orange-rgb is documented but has no usage in the Pulse repo.
Fix: Added a note that it powers the .glow-orange utility in the ciphera-ui preset. The preset injects both the variable and the .glow-orange class, which uses rgba(var(--color-brand-orange-rgb), 0.5) for its box-shadow.
Why: The usage lives in the shared preset (ciphera-ui), not in Pulse. Documenting this makes it clear the variable is used and where it comes from.

Issue: --color-brand-orange-rgb is documented but has no usage in the Pulse repo. Fix: Added a note that it powers the .glow-orange utility in the ciphera-ui preset. The preset injects both the variable and the .glow-orange class, which uses rgba(var(--color-brand-orange-rgb), 0.5) for its box-shadow. Why: The usage lives in the shared preset (ciphera-ui), not in Pulse. Documenting this makes it clear the variable is used and where it comes from.
greptile-apps[bot] commented 2026-02-17 20:25:09 +00:00 (Migrated from github.com)
Copy Link

Greptile Summary

This is a pure documentation PR that backfills two previously undocumented changes made in v0.7.0-alpha:

  • CHANGELOG.md: Adds a Changed entry for the authenticated footer container being narrowed from max-w-7xl to max-w-6xl to match the rest of the app layout. The actual code change was made in a prior commit (1574d5e) and is confirmed in components/Footer.tsx:49.
  • docs/DESIGN_SYSTEM.md: Documents the two CSS custom properties (--color-brand-orange and --color-brand-orange-rgb) that are injected by the @ciphera-net/ui Tailwind preset, and adds a usage note directing developers to use var(--color-brand-orange) in SVG/Recharts contexts where Tailwind classes are not applicable.

Both changes are accurate relative to the actual codebase. Two minor housekeeping issues were found in DESIGN_SYSTEM.md: the Last Updated frontmatter date was not bumped (still reads 2026-02-06), and the @ciphera-net/ui version reference in the Integration section is stale (^0.0.45 vs the current ^0.0.57 in package.json).

Confidence Score: 5/5

  • This PR is safe to merge — it is documentation-only with no runtime code changes.
  • Both changed files are Markdown documentation. The content accurately reflects existing code in the repository. The two issues found (stale date and stale version number) are cosmetic and do not affect correctness or safety.
  • No files require special attention, though docs/DESIGN_SYSTEM.md has two minor stale metadata values worth fixing before merging.

Important Files Changed
Filename Overview
CHANGELOG.md Adds a single changelog entry for the footer container alignment change (max-w-7xl → max-w-6xl). Entry is accurate, well-scoped, and follows the existing format.
docs/DESIGN_SYSTEM.md Documents two new CSS custom properties injected by the @ciphera-net/ui preset and adds a usage note for SVG/Recharts contexts. Two minor housekeeping issues: the Last Updated date was not bumped, and the @ciphera-net/ui version reference is stale (^0.0.45 vs actual ^0.0.57).

Flowchart

flowchart TD
    A["@ciphera-net/ui preset\n(v0.0.57)"] -->|"injects CSS variables"| B["--color-brand-orange: #FD5E0F\n--color-brand-orange-rgb: 253, 94, 15"]
    A -->|"provides utility class"| C[".glow-orange\nbox-shadow: rgba(var(--color-brand-orange-rgb), 0.5)"]
    B -->|"used in"| D["SVG / Recharts components\n(e.g. uptime/page.tsx)"]
    B -->|"used in"| E["Custom rgba() expressions"]
    F["Footer.tsx\n(authenticated)"] -->|"container width"| G["max-w-6xl\n(matches dashboard & page-container-app)"]
    H["DESIGN_SYSTEM.md"] -->|"documents"| B
    H -->|"documents"| G
    I["CHANGELOG.md"] -->|"records"| G

Last reviewed commit: f9eb6bf

<h3>Greptile Summary</h3> This is a pure documentation PR that backfills two previously undocumented changes made in v0.7.0-alpha: - **CHANGELOG.md**: Adds a `Changed` entry for the authenticated footer container being narrowed from `max-w-7xl` to `max-w-6xl` to match the rest of the app layout. The actual code change was made in a prior commit (`1574d5e`) and is confirmed in `components/Footer.tsx:49`. - **docs/DESIGN_SYSTEM.md**: Documents the two CSS custom properties (`--color-brand-orange` and `--color-brand-orange-rgb`) that are injected by the `@ciphera-net/ui` Tailwind preset, and adds a usage note directing developers to use `var(--color-brand-orange)` in SVG/Recharts contexts where Tailwind classes are not applicable. Both changes are accurate relative to the actual codebase. Two minor housekeeping issues were found in `DESIGN_SYSTEM.md`: the `Last Updated` frontmatter date was not bumped (still reads `2026-02-06`), and the `@ciphera-net/ui` version reference in the Integration section is stale (`^0.0.45` vs the current `^0.0.57` in `package.json`). <h3>Confidence Score: 5/5</h3> - This PR is safe to merge — it is documentation-only with no runtime code changes. - Both changed files are Markdown documentation. The content accurately reflects existing code in the repository. The two issues found (stale date and stale version number) are cosmetic and do not affect correctness or safety. - No files require special attention, though `docs/DESIGN_SYSTEM.md` has two minor stale metadata values worth fixing before merging. <details><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | CHANGELOG.md | Adds a single changelog entry for the footer container alignment change (max-w-7xl → max-w-6xl). Entry is accurate, well-scoped, and follows the existing format. | | docs/DESIGN_SYSTEM.md | Documents two new CSS custom properties injected by the @ciphera-net/ui preset and adds a usage note for SVG/Recharts contexts. Two minor housekeeping issues: the Last Updated date was not bumped, and the @ciphera-net/ui version reference is stale (^0.0.45 vs actual ^0.0.57). | </details> </details> <h3>Flowchart</h3> ```mermaid flowchart TD A["@ciphera-net/ui preset\n(v0.0.57)"] -->|"injects CSS variables"| B["--color-brand-orange: #FD5E0F\n--color-brand-orange-rgb: 253, 94, 15"] A -->|"provides utility class"| C[".glow-orange\nbox-shadow: rgba(var(--color-brand-orange-rgb), 0.5)"] B -->|"used in"| D["SVG / Recharts components\n(e.g. uptime/page.tsx)"] B -->|"used in"| E["Custom rgba() expressions"] F["Footer.tsx\n(authenticated)"] -->|"container width"| G["max-w-6xl\n(matches dashboard & page-container-app)"] H["DESIGN_SYSTEM.md"] -->|"documents"| B H -->|"documents"| G I["CHANGELOG.md"] -->|"records"| G ``` <sub>Last reviewed commit: f9eb6bf</sub>
greptile-apps[bot] (Migrated from github.com) reviewed 2026-02-17 20:25:19 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

<sub>2 files reviewed, 2 comments</sub> <sub>[Edit Code Review Agent Settings](https://app.greptile.com/review/github) | [Greptile](https://greptile.com?utm_source=greptile_expert&utm_medium=github&utm_campaign=code_reviews)</sub>
greptile-apps[bot] commented 2026-02-17 20:25:21 +00:00 (Migrated from github.com)
Copy Link
Additional Comments (2)

docs/DESIGN_SYSTEM.md
Last Updated date not bumped

This PR adds new content to the design system (two new color variables and a new usage note), but the Last Updated date on line 4 remains 2026-02-06. It should be updated to reflect when this change was made.

**Last Updated:** 2026-02-17

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/DESIGN_SYSTEM.md
Line: 4:4

Comment:
**`Last Updated` date not bumped**

This PR adds new content to the design system (two new color variables and a new usage note), but the `Last Updated` date on line 4 remains `2026-02-06`. It should be updated to reflect when this change was made.

```suggestion
**Last Updated:** 2026-02-17  
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

docs/DESIGN_SYSTEM.md
Stale @ciphera-net/ui version reference

The version listed here is ^0.0.45, but package.json currently pins it at ^0.0.57. Since this PR is already updating the design system to reflect the new color variables injected by the preset, the version number should be kept in sync too.

**Version:** `^0.0.57`
Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/DESIGN_SYSTEM.md
Line: 914:914

Comment:
**Stale `@ciphera-net/ui` version reference**

The version listed here is `^0.0.45`, but `package.json` currently pins it at `^0.0.57`. Since this PR is already updating the design system to reflect the new color variables injected by the preset, the version number should be kept in sync too.

```suggestion
**Version:** `^0.0.57`
```

How can I resolve this? If you propose a fix, please make it concise.
<details> <summary>Additional Comments (2)</summary> **`docs/DESIGN_SYSTEM.md`** **`Last Updated` date not bumped** This PR adds new content to the design system (two new color variables and a new usage note), but the `Last Updated` date on line 4 remains `2026-02-06`. It should be updated to reflect when this change was made. ```suggestion **Last Updated:** 2026-02-17 ``` <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> <details><summary>Prompt To Fix With AI</summary> `````markdown This is a comment left during a code review. Path: docs/DESIGN_SYSTEM.md Line: 4:4 Comment: **`Last Updated` date not bumped** This PR adds new content to the design system (two new color variables and a new usage note), but the `Last Updated` date on line 4 remains `2026-02-06`. It should be updated to reflect when this change was made. ```suggestion **Last Updated:** 2026-02-17 ``` <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise. ````` </details> --- **`docs/DESIGN_SYSTEM.md`** **Stale `@ciphera-net/ui` version reference** The version listed here is `^0.0.45`, but `package.json` currently pins it at `^0.0.57`. Since this PR is already updating the design system to reflect the new color variables injected by the preset, the version number should be kept in sync too. ```suggestion **Version:** `^0.0.57` ``` <details><summary>Prompt To Fix With AI</summary> `````markdown This is a comment left during a code review. Path: docs/DESIGN_SYSTEM.md Line: 914:914 Comment: **Stale `@ciphera-net/ui` version reference** The version listed here is `^0.0.45`, but `package.json` currently pins it at `^0.0.57`. Since this PR is already updating the design system to reflect the new color variables injected by the preset, the version number should be kept in sync too. ```suggestion **Version:** `^0.0.57` ``` How can I resolve this? If you propose a fix, please make it concise. ````` </details> </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
usman
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ciphera-net/pulse#31
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?