ciphera-net/pulse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

chore: update CHANGELOG.md and DESIGN_SYSTEM.md #31

Merged
uz1mani merged 2 commits from staging into main 2026-02-17 20:25:46 +00:00
Conversation 7 Commits 2 Files Changed 2 +6
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
- **Hardcoded brand colors.** Uptime page chart uses CSS variable var(--color-brand-orange) instead of #FD5E0F.
- **Selection styling.** Removed redundant selection:bg-brand-orange/20 from page wrappers; relies on ciphera-ui base styles.
- **Inline spinners.** Dashboard widgets (TopReferrers, Locations, TechSpecs, Campaigns, ContentStats), notifications page, and OrganizationSettings now use Spinner from ciphera-ui.
- **Footer layout.** Authenticated footer container aligned to max-w-6xl (matches site dashboard and page-container-app).
### Removed

5
docs/DESIGN_SYSTEM.md
View File

@@ -21,10 +21,15 @@ This document defines the visual language and design patterns for Pulse Analytic
--brand-orange: #FD5E0F;
greptile-apps[bot] commented 2026-02-17 20:20:18 +00:00 (Migrated from github.com)
Review
Copy Link

--color-brand-orange-rgb documented but unused

This variable is defined in the design system doc as a convenience for rgba() usage, but a search across all .tsx, .ts, and .css files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/DESIGN_SYSTEM.md
Line: 26:26

Comment:
**`--color-brand-orange-rgb` documented but unused**

This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist.

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.
**`--color-brand-orange-rgb` documented but unused** This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist. <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> <details><summary>Prompt To Fix With AI</summary> `````markdown This is a comment left during a code review. Path: docs/DESIGN_SYSTEM.md Line: 26:26 Comment: **`--color-brand-orange-rgb` documented but unused** This variable is defined in the design system doc as a convenience for `rgba()` usage, but a search across all `.tsx`, `.ts`, and `.css` files in the project shows it is not used anywhere yet. Consider either adding a note clarifying it is reserved for future use, or waiting to document it until there is an actual usage to point to — to avoid developers searching for an example that doesn't exist. <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise. ````` </details>
uz1mani commented 2026-02-17 20:23:06 +00:00 (Migrated from github.com)
Review
Copy Link

Issue: --color-brand-orange-rgb is documented but has no usage in the Pulse repo.
Fix: Added a note that it powers the .glow-orange utility in the ciphera-ui preset. The preset injects both the variable and the .glow-orange class, which uses rgba(var(--color-brand-orange-rgb), 0.5) for its box-shadow.
Why: The usage lives in the shared preset (ciphera-ui), not in Pulse. Documenting this makes it clear the variable is used and where it comes from.

Issue: --color-brand-orange-rgb is documented but has no usage in the Pulse repo. Fix: Added a note that it powers the .glow-orange utility in the ciphera-ui preset. The preset injects both the variable and the .glow-orange class, which uses rgba(var(--color-brand-orange-rgb), 0.5) for its box-shadow. Why: The usage lives in the shared preset (ciphera-ui), not in Pulse. Documenting this makes it clear the variable is used and where it comes from.
--brand-orange-hover: #E54E00; /* Darker for hover states */
/* Injected by @ciphera-net/ui preset — use in SVG, Recharts, rgba() */
--color-brand-orange: #FD5E0F;
--color-brand-orange-rgb: 253, 94, 15; /* Used by .glow-orange utility; also for custom rgba(var(--color-brand-orange-rgb), 0.5) */
/* Usage */
- Primary CTAs, links, focus rings
- Accent elements, badges
- Never use for large backgrounds (too vibrant)
- var(--color-brand-orange) for SVG/Recharts where Tailwind classes don't apply
```
### Neutral Scale